Changing the subquery builder for the Oracle #5999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrey Pyzhikov <5071@mail.ru>
kenjis
added
the
bug
|
Subquery has not been released. Do we need it to be written in the changelog? |
|
@paulbalandan An improvement to the BaseBuilder::buildSubquery() method, namely adding an alias, has not yet been released. If this PR and the fix in the changelog are merged before the release, then it seems to me that it makes no sense to further clarify the changes from this PR. |
|
Ohh. I thought this was documented already. Thanks for the clarification. |
samsonasik
approved these changes
May 20, 2022
MGatner
added
the
database
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because Oracle does not support using the
ASkeyword for table aliases.This PR removes the
ASkeyword when building subqueries.Checklist: